chore!: Remove DeprecatedVectorStart - #12740
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 3c286db | Previous: a8889ca | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_blob |
153 s |
93 s |
1.65 |
test_report_zkpassport_noir-ecdsa_ |
3 s |
2 s |
1.50 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Brillig Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 3c286db | Previous: a8889ca | Ratio |
|---|---|---|---|
rollup-tx-merge |
0.002 s |
0.001 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
I've made PRs for 3 of the failing repos, the remaining 2 (noir_json_parser & sparse_array) depend on noir_sort and will need to have the tag for that updated once its pr is merged. |
jfecher
changed the title
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 86a2e3c | Previous: 30638e1 | Ratio |
|---|---|---|---|
rollup-tx-base-private |
23.9 s |
19.48 s |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'ACVM Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 1e2cb9a | Previous: e65591d | Ratio |
|---|---|---|---|
purely_sequential_opcodes |
128202 ns/iter (± 166) |
98791 ns/iter (± 736) |
1.30 |
perfectly_parallel_opcodes |
113652 ns/iter (± 1356) |
88025 ns/iter (± 1585) |
1.29 |
perfectly_parallel_batch_inversion_opcodes |
3040969 ns/iter (± 1592) |
2359903 ns/iter (± 1761) |
1.29 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 3c286db | Previous: a8889ca | Ratio |
|---|---|---|---|
sha512-100-bytes |
0.058 s |
0.035 s |
1.66 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
2 participants
Problem Resolved
Resolves #12732
Summary of Changes
These were originally left in during the switch to
@[...]because so many projects were still using the old syntax. It has been enough time for them to migrate (or re-format) now, and leaving&[..]complicates taking a reference to an array as noted in the issue, so I have removed the old deprecated syntax.User Documentation
Check one:
PR Checklist
cargo fmton default settings.